chore(tests): Fix tests and improve coverage.

Author: Portugal, Marcelo

src/features/selection/js/selection.js

@@ -254,7 +254,7 @@
                  * @description Selects all visible rows.  Does nothing if multiSelect = false
                  * @param {Event} event object if raised from an event
                  */
-                selectAllVisibleRows: function (evt) {
+                selectAllVisibleRows: function (event) {
                   if (grid.options.multiSelect !== false) {
                     var changedRows = [];
                     var rowCache = [];

test/unit/i18n/directives.spec.js

@@ -1,14 +1,14 @@
-describe('i18n Directives', function () {
-  var gridUtil;
-  var scope;
-  var element;
-  var uiGridController;
-  var recompile;
+describe('i18n Directives', function() {
+  var $compile, $rootScope, gridUtil, element, recompile, scope;
 
-  beforeEach(module('ui.grid'));
+  beforeEach(function() {
+    module('ui.grid');
 
-  beforeEach(inject(function ($rootScope, $compile, $controller, _gridUtil_, $templateCache, $timeout) {
-    gridUtil = _gridUtil_;
+    inject(function (_$rootScope_, _$compile_, _gridUtil_) {
+      $compile = _$compile_;
+      $rootScope = _$rootScope_;
+      gridUtil = _gridUtil_;
+    });
 
     scope = $rootScope.$new();
     scope.options = {};
@@ -24,45 +24,45 @@ describe('i18n Directives', function () {
 
     recompile = function () {
       $compile(element)(scope);
-      $rootScope.$digest();
+      $rootScope.$apply();
     };
-  }));
-
+  });
 
-  describe('ui-translate directive', function () {
-    it('should translate', function () {
-      element = angular.element('<div ui-i18n="en"><p ui-translate="search.placeholder"></p></div>');
+  describe('ui-translate directive', function() {
+    beforeEach(function() {
+      scope.lang = 'en';
+      element = angular.element('<div ui-i18n="lang"><p ui-translate="search.placeholder"></p></div>');
       recompile();
-
+    });
+    it('should translate', function() {
       expect(element.find('p').text()).toBe('Search...');
     });
   });
 
-  describe('ui-t directive', function () {
-    it('should translate', function () {
+  describe('ui-t directive', function() {
+    it('should translate', function() {
       element = angular.element('<div ui-i18n="en"><p ui-t="search.placeholder"></p></div>');
       recompile();
 
       expect(element.find('p').text()).toBe('Search...');
     });
   });
 
-  describe('t filter', function () {
-    it('should translate', function () {
+  describe('t filter', function() {
+    it('should translate', function() {
       element = angular.element('<div ui-i18n="en"><p>{{"search.placeholder" | t}}</p></div>');
       recompile();
 
       expect(element.find('p').text()).toBe('Search...');
     });
   });
 
-  describe('uiTranslate filter', function () {
-    it('should translate', function () {
+  describe('uiTranslate filter', function() {
+    it('should translate', function() {
       element = angular.element('<div ui-i18n="en"><p>{{"search.placeholder" | uiTranslate}}</p></div>');
       recompile();
 
       expect(element.find('p').text()).toBe('Search...');
     });
   });
-
 });

test/unit/i18n/i18nService.spec.js

@@ -1,37 +1,58 @@
 describe('i18nService', function () {
-  var i18nService;
-  beforeEach(module('ui.grid'));
+  var i18nConstants, i18nService;
 
-  beforeEach(inject(function (_i18nService_) {
-    i18nService = _i18nService_;
-  }));
+  beforeEach(function() {
+    module('ui.grid');
+    inject(function (_i18nConstants_, _i18nService_) {
+      i18nConstants = _i18nConstants_;
+      i18nService = _i18nService_;
+    });
+  });
 
-  describe('i18n service', function () {
-    it('should default to English', function () {
+  describe('i18n service', function() {
+    it('should default to English', function() {
       expect(i18nService.getCurrentLang()).toBe('en');
       expect(i18nService.get().search.placeholder).toBe('Search...');
     });
-    it('should set a new Current', function () {
+    it('should set a new Current', function() {
       i18nService.setCurrentLang('fr');
       expect(i18nService.getCurrentLang()).toBe('fr');
       expect(i18nService.get().search.placeholder).toBe('Recherche...');
     });
-    it('should add a language', function () {
-      i18nService.add('tst',{test:'testlang'});
-      i18nService.setCurrentLang('tst');
-      expect(i18nService.get().test).toBe('testlang');
+    describe('add', function() {
+      it('should add a language when langs is a string', function() {
+        i18nService.add('tst',{test:'testlang'});
+        i18nService.setCurrentLang('tst');
+        expect(i18nService.get().test).toBe('testlang');
+      });
+      it('should add multiple languages when langs is an array', function() {
+        i18nService.add(['tst1', 'tst2'], {test:'testlang'});
+        i18nService.setCurrentLang('tst1');
+        expect(i18nService.get().test).toBe('testlang');
+        i18nService.setCurrentLang('tst2');
+        expect(i18nService.get().test).toBe('testlang');
+      });
+      it('should not add null languages', function() {
+        i18nService.add([null], {test:'testlang'});
+        i18nService.setCurrentLang(null);
+        expect(i18nService.get().test).toBeUndefined();
+      });
     });
-    it('should return all langs', function () {
+    it('should return all langs', function() {
       var langs = i18nService.getAllLangs();
       expect(langs.length).toBeGreaterThan(8);
     });
-    it('should get safe text', function () {
-      var text = i18nService.getSafeText('search.placeholder');
-      expect(text).toBe('Search...');
-    });
-    it('should get safe text for missing property', function () {
-      var text = i18nService.getSafeText('search.bad.text');
-      expect(text).toBe('[MISSING]');
+
+    describe('getSafeText', function() {
+      it('should get safe text when text is defined', function() {
+        expect(i18nService.getSafeText('search.placeholder')).toBe('Search...');
+      });
+      it('should get safe text for missing property', function() {
+        expect(i18nService.getSafeText('search.bad.text')).toBe('[MISSING]');
+      });
+      it('should get missing text when language is missing or nonexistent', function() {
+        expect(i18nService.getSafeText('search.placeholder', 'valerian')).toBe(i18nConstants.MISSING);
+      });
     });
   });
 });