Skip to content

Commit 0e8f549

Browse files
authored
fix: swap blue/red in cloudeditor themes to reduces usage of red (#5492)
Some users reported that the usage of red for variables could be confusing because users associate red with errors in their code. This swaps blue and red in the themes to reduce the usage of red. As a follow-up we could reduces the bright red-ness of our red to reduce the association with errors.
1 parent 54cbc5e commit 0e8f549

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

src/theme/cloud_editor-css.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ module.exports = `
7676
}
7777
7878
.ace-cloud_editor .ace_meta.ace_tag {
79-
color: #d1000a;
79+
color: #2963d6;
8080
}
8181
8282
.ace-cloud_editor .ace_constant {
@@ -92,7 +92,7 @@ module.exports = `
9292
}
9393
9494
.ace-cloud_editor .ace_support.ace_function {
95-
color: #2963d6;
95+
color: #d1000a;
9696
}
9797
9898
.ace-cloud_editor .ace_support.ace_class {
@@ -105,7 +105,7 @@ module.exports = `
105105
106106
.ace-cloud_editor .ace_invalid.ace_illegal {
107107
color: #ffffff;
108-
background-color: #d1000a;
108+
background-color: #2963d6;
109109
}
110110
111111
.ace-cloud_editor .ace_invalid.ace_deprecated {
@@ -128,7 +128,7 @@ module.exports = `
128128
}
129129
130130
.ace-cloud_editor .ace_variable {
131-
color: #d1000a;
131+
color: #2963d6;
132132
}
133133
134134
.ace-cloud_editor .ace_meta.ace_selector {
@@ -140,22 +140,22 @@ module.exports = `
140140
}
141141
142142
.ace-cloud_editor .ace_entity.ace_name.ace_function {
143-
color: #2963d6;
143+
color: #d1000a;
144144
}
145145
146146
.ace-cloud_editor .ace_entity.ace_name.ace_tag {
147-
color: #d1000a;
147+
color: #2963d6;
148148
}
149149
150150
.ace-cloud_editor .ace_heading {
151-
color: #2963d6;
151+
color: #d1000a;
152152
}
153153
154154
.ace-cloud_editor .ace_xml-pe {
155155
color: #a26202;
156156
}
157157
.ace-cloud_editor .ace_doctype {
158-
color: #d1000a;
158+
color: #2963d6;
159159
}
160160
161161
.ace-cloud_editor .ace_tooltip {

src/theme/cloud_editor_dark-css.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ module.exports = `
8888
}
8989
9090
.ace-cloud_editor_dark .ace_support.ace_function {
91-
color: #66b2f0;
91+
color: #e96a71;
9292
}
9393
9494
.ace-cloud_editor_dark .ace_support.ace_class {
@@ -101,7 +101,7 @@ module.exports = `
101101
102102
.ace-cloud_editor_dark .ace_invalid.ace_illegal {
103103
color: #dcdfe4;
104-
background-color: #e96a71;
104+
background-color:#66b2f0;
105105
}
106106
107107
.ace-cloud_editor_dark .ace_invalid.ace_deprecated {
@@ -124,7 +124,7 @@ module.exports = `
124124
}
125125
126126
.ace-cloud_editor_dark .ace_variable {
127-
color: #e96a71;
127+
color:#66b2f0;
128128
}
129129
130130
.ace-cloud_editor_dark .ace_meta.ace_selector {
@@ -136,29 +136,29 @@ module.exports = `
136136
}
137137
138138
.ace-cloud_editor_dark .ace_entity.ace_name.ace_function {
139-
color: #66b2f0;
139+
color: #e96a71;
140140
}
141141
142142
.ace-cloud_editor_dark .ace_entity.ace_name.ace_tag {
143-
color: #e96a71;
143+
color:#66b2f0;
144144
}
145145
.ace-cloud_editor_dark .ace_heading {
146-
color: #66b2f0;
146+
color: #e96a71;
147147
}
148148
149149
.ace-cloud_editor_dark .ace_xml-pe {
150150
color: #e5c383;
151151
}
152152
.ace-cloud_editor_dark .ace_doctype {
153-
color: #e96a71;
153+
color:#66b2f0;
154154
}
155155
156156
.ace-cloud_editor_dark .ace_entity.ace_name.ace_tag,
157157
.ace-cloud_editor_dark .ace_entity.ace_other.ace_attribute-name,
158158
.ace-cloud_editor_dark .ace_meta.ace_tag,
159159
.ace-cloud_editor_dark .ace_string.ace_regexp,
160160
.ace-cloud_editor_dark .ace_variable {
161-
color: #e96a71;
161+
color:#66b2f0;
162162
}
163163
164164
.ace-cloud_editor_dark .ace_tooltip {

0 commit comments

Comments
 (0)