Pull requests are highly appreciated. Here's a quick guide.
Please note: we're currently using the make utility to condense tasks run via Composer. If you're contributing outside of Docker, or you're using an operating system without the make utility installed, you can review the Makefile and run the appropriate commands manually.
Fork, then clone the repo:
git clone git@github.com:your-username/reactphp-http-middleware-custom-request-body-parers.git
Set up your machine:
composer install
Make sure the tests pass:
make unit
Make your change. Add tests for your change. Make the tests pass:
make unit
Before committing and submitting your pull request make sure it passes PSR2 coding style, unit tests pass and pass on all supported PHP versions:
make contrib
Push to your fork and submit a pull request.
At this point you're waiting on me. I like to at least comment on pull requests within a day or two. I may suggest some changes or improvements or alternatives.
Some things that will increase the chance that your pull request is accepted:
- Write tests.
- Follow PSR2 (travis will also check for this).
- Write a good commit message.