-
Notifications
You must be signed in to change notification settings - Fork 19
fix: catch non-numeric min_coverage input #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
if I am right about the Expected behavior I could open a PR to fix it |
Hi @maxzod ! Thanks for opening an issue! I don't think we should allow %. I think the input should only be numeric, not a string. We are not planning to work on this ourselves since this is easily resolvable by using a sensible input type. If you wish to work on some error logic to ensure the input is numeric, we're willing to accept the feature. |
@alestiago |
%
results un expected behavior
@maxzod I've unassigned you for now due to inactivity, if you wish to resume the work here let me know. Anyone else is also welcome to work on this Pull Request, let us know here with a comment 💙 ! |
Hey @alestiago, can I work on this one? |
This has now been resolved by #290, the change will be visible when a new release is available. |
Describe the bug
current coverage is > 50%
in this workflow
it should pass and it does
but in this flow
note: I added the percentage symbol to
min_coverage
the result is falling
Expected behavior
either to remove % and work as usual 0r to throw a clear exception to tell the developer what is wrong with his workflow
The text was updated successfully, but these errors were encountered: