fix: ensure embedded PostgreSQL is cleaned up on crash or forced termination (Fix JabRef#12844)

UdayHE · UdayHE · commit fe727947b733 · 2025-04-15T19:55:59.000+05:30
* Fix for trag-bot comments.
diff --git a/src/main/java/org/jabref/logic/search/PostgreProcessCleaner.java b/src/main/java/org/jabref/logic/search/PostgreProcessCleaner.java
@@ -76,8 +76,7 @@ private void destroyPostgresProcess(int port) throws InterruptedException {
     }
 
     private void destroyProcessByPID(long pid) throws InterruptedException {
-        Optional<ProcessHandle> aliveProcess = ProcessHandle.of(pid)
-                .filter(ProcessHandle::isAlive);
+        Optional<ProcessHandle> aliveProcess = ProcessHandle.of(pid).filter(ProcessHandle::isAlive);
         if (aliveProcess.isPresent()) {
             aliveProcess.get().destroy();
             Thread.sleep(PostgreProcessCleaner.POSTGRES_SHUTDOWN_WAIT_MILLIS);

Original file line number	Diff line number	Diff line change
`@@ -76,8 +76,7 @@ private void destroyPostgresProcess(int port) throws InterruptedException {`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`private void destroyProcessByPID(long pid) throws InterruptedException {`
`79`		`- Optional<ProcessHandle> aliveProcess = ProcessHandle.of(pid)`
`80`		`- .filter(ProcessHandle::isAlive);`
	`79`	`+ Optional<ProcessHandle> aliveProcess = ProcessHandle.of(pid).filter(ProcessHandle::isAlive);`
`81`	`80`	`if (aliveProcess.isPresent()) {`
`82`	`81`	`aliveProcess.get().destroy();`
`83`	`82`	`Thread.sleep(PostgreProcessCleaner.POSTGRES_SHUTDOWN_WAIT_MILLIS);`