diff --git a/packages/core/src/comments/threadstore/ThreadStore.ts b/packages/core/src/comments/threadstore/ThreadStore.ts index 4d4fcd3438..362bfb274e 100644 --- a/packages/core/src/comments/threadstore/ThreadStore.ts +++ b/packages/core/src/comments/threadstore/ThreadStore.ts @@ -27,7 +27,7 @@ export abstract class ThreadStore { head: number; anchor: number; }; - yjs: { + yjs?: { head: any; anchor: any; }; diff --git a/packages/core/src/editor/BlockNoteEditor.ts b/packages/core/src/editor/BlockNoteEditor.ts index 55339f1eb1..2fc754bbf7 100644 --- a/packages/core/src/editor/BlockNoteEditor.ts +++ b/packages/core/src/editor/BlockNoteEditor.ts @@ -587,12 +587,6 @@ export class BlockNoteEditor< ); } - if (newOptions.comments && !collaborationEnabled) { - throw new Error( - "Comments are only supported when collaboration is enabled, please set the collaboration option" - ); - } - const initialContent = newOptions.initialContent || (collaborationEnabled diff --git a/packages/core/src/extensions/Comments/CommentMark.ts b/packages/core/src/extensions/Comments/CommentMark.ts index f4c02a3e6d..072f24c7c3 100644 --- a/packages/core/src/extensions/Comments/CommentMark.ts +++ b/packages/core/src/extensions/Comments/CommentMark.ts @@ -5,7 +5,6 @@ export const CommentMark = Mark.create({ excludes: "", inclusive: false, keepOnSplit: true, - group: "blocknoteIgnore", // ignore in blocknote json addAttributes() { // Return an object with attribute configuration diff --git a/packages/core/src/extensions/Comments/CommentsPlugin.ts b/packages/core/src/extensions/Comments/CommentsPlugin.ts index 481f6016f5..53cdb240cc 100644 --- a/packages/core/src/extensions/Comments/CommentsPlugin.ts +++ b/packages/core/src/extensions/Comments/CommentsPlugin.ts @@ -283,7 +283,9 @@ export class CommentsPlugin extends EventEmitter { head: pmSelection.head, anchor: pmSelection.anchor, }, - yjs: getRelativeSelection(ystate.binding, view.state), + yjs: ystate + ? getRelativeSelection(ystate.binding, view.state) + : undefined, // if we're not using yjs }; await this.threadStore.addThreadToDocument({