-
Notifications
You must be signed in to change notification settings - Fork 12
Update dependencies #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f657c0d
to
d4664d5
Compare
The CI build failures seem to indicate something wrong with
Yeah, the
Given the unit test coverage of the library at this point, for a development dependency update like this I would dare say |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need that package-lock.json sorted out.
package-lock.json
Outdated
"dev": true, | ||
"requires": { | ||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge issues here.
I think the correct remedy is:
git checkout origin/master -- package-lock.json
npm install
git add package-lock.json
git commit -m "Updated package-lock.json"
git push
Typically when I update npm install webpack
git commit package.json
rm -rf node_modules
npm install
git commit package-lock.json Inter-branch conflicts can also appear, which is part of why I recreate the lock from a fresh set of packages each time I change it. |
The new package lock should also fix #89 I'm not sure how I think the only hard dependency should be |
Discovered today when running
|
It seems like manually rebasing a branch before merging/squash-and-merging can uncover these. It's easy to get |
This is ready to go again. Sorry for the rebase issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With npm test
I see all 70 tests passing as well
This updates the project's dependencies to the latest.
I have put this PR through some testing but I can't say for sure that this won't break anything.
Testing
Stolen from @dmsnell: Testing is a bit tricky but I found it easiest to link this library with the
Simplenote electron app and build them together via npm link.