Skip to content

Commit 7f756c1

Browse files
authored
Docker: Unified node config session-timeout from generated TOML file (#2598)
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
1 parent d43142d commit 7f756c1

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

NodeBase/generate_config

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ if [[ -z "${SE_NODE_GRID_URL}" ]]; then
4444
else
4545
echo "grid-url = \"${SE_NODE_GRID_URL}\"" >>"$FILENAME"
4646
fi
47-
echo "session-timeout = \"${SE_NODE_SESSION_TIMEOUT}\"" >>"$FILENAME"
47+
echo "session-timeout = ${SE_NODE_SESSION_TIMEOUT}" >>"$FILENAME"
4848
echo "override-max-sessions = ${SE_NODE_OVERRIDE_MAX_SESSIONS}" >>"$FILENAME"
4949
echo "detect-drivers = false" >>"$FILENAME"
5050
echo "drain-after-session-count = ${DRAIN_AFTER_SESSION_COUNT:-$SE_DRAIN_AFTER_SESSION_COUNT}" >>"$FILENAME"

NodeBase/start-selenium-node.sh

-4
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,6 @@ if [[ -z "${SE_EVENT_BUS_SUBSCRIBE_PORT}" ]]; then
5353
exit 1
5454
fi
5555

56-
if [ ! -z "$SE_NODE_SESSION_TIMEOUT" ]; then
57-
append_se_opts "--session-timeout" "${SE_NODE_SESSION_TIMEOUT}"
58-
fi
59-
6056
if [ ! -z "$SE_NODE_ENABLE_MANAGED_DOWNLOADS" ]; then
6157
append_se_opts "--enable-managed-downloads" "${SE_NODE_ENABLE_MANAGED_DOWNLOADS}"
6258
fi

Standalone/generate_config

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ if [[ -z "${SE_NODE_GRID_URL}" ]]; then
2525
else
2626
echo "grid-url = \"${SE_NODE_GRID_URL}\"" >>"$FILENAME"
2727
fi
28-
echo "session-timeout = \"${SE_NODE_SESSION_TIMEOUT}\"" >>"$FILENAME"
28+
echo "session-timeout = ${SE_NODE_SESSION_TIMEOUT}" >>"$FILENAME"
2929
echo "override-max-sessions = ${SE_NODE_OVERRIDE_MAX_SESSIONS}" >>"$FILENAME"
3030
echo "detect-drivers = false" >>"$FILENAME"
3131
echo "drain-after-session-count = ${DRAIN_AFTER_SESSION_COUNT:-$SE_DRAIN_AFTER_SESSION_COUNT}" >>"$FILENAME"

0 commit comments

Comments
 (0)