Skip to content

AbstractGraph refactor #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
f-aguzzi opened this issue Jul 31, 2024 · 3 comments
Closed

AbstractGraph refactor #497

f-aguzzi opened this issue Jul 31, 2024 · 3 comments
Assignees
Labels
refactor refactoring of folders

Comments

@f-aguzzi
Copy link
Member

Is your feature request related to a problem? Please describe.
The code:

  • is messy (long module, irregular implementation)
  • has known bugs (some custom embeddings do not work even if implemented, see Not match Gemini embeddings model #496)
  • is hard to read (irregular formatting)
  • is difficult to understand for newcomers and contributors

Describe the solution you'd like
Ideally, the module should be rewritten from scratch at some point. In the meanwhile, all dead code should be removed (for example, the RAG node has been deprecated in all graphs, so the sections about embeddings have become useless).
A better use of LangChain and of its latest features should remove some of the complexity.

Describe alternatives you've considered
Possible alternatives will be considered and explained in the follow-ups to this issue.

@f-aguzzi f-aguzzi added the refactor refactoring of folders label Jul 31, 2024
@f-aguzzi f-aguzzi self-assigned this Jul 31, 2024
@f-aguzzi f-aguzzi added this to the AbstractGraph refactor milestone Jul 31, 2024
@f-aguzzi
Copy link
Member Author

f-aguzzi commented Jul 31, 2024

The main tasks are:

  • clean up the code and enforce correct formatting
  • remove dead imports
  • transplant the embedding initialization blocks into the RAGNode

@f-aguzzi
Copy link
Member Author

The process should fix the following issues too:

@f-aguzzi
Copy link
Member Author

f-aguzzi commented Aug 2, 2024

Also this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor refactoring of folders
Projects
None yet
Development

No branches or pull requests

2 participants