Skip to content

Notification as Default Severity #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucasborin opened this issue Apr 9, 2021 · 0 comments · Fixed by #376
Closed

Notification as Default Severity #368

lucasborin opened this issue Apr 9, 2021 · 0 comments · Fixed by #376
Assignees
Labels
enhancement An enhancement or scope enhancement

Comments

@lucasborin
Copy link
Member

lucasborin commented Apr 9, 2021

There are several feedbacks coming from distinct stakeholders related to the code pal severities, and in a short, I agree with them.

Code pal is a tool based on the Clean ABAP style guide. It should not define what is an error or what is a warning, but so notify the developer that something was identified which is not compliant with the style guide. It is just automation.

It is the development team's responsibility, together with their Architect and Quality Engineer, to decide if a rule is a warning or an error.

Therefore, I propose to set all the Checks as notifications by default.

@lucasborin lucasborin added the enhancement An enhancement or scope enhancement label Apr 9, 2021
@lucasborin lucasborin self-assigned this Apr 9, 2021
@lucasborin lucasborin linked a pull request Apr 15, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or scope enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant