review changes (including remove shasum from ci_build_test in cmake_external)

Author: tyler-yankee

drake_bazel_external/.bazelignore

@@ -1,2 +1 @@
-# Used for setup, do not build
 drake

drake_bazel_external_legacy/.bazelignore

@@ -1,2 +1 @@
-# Used for setup, do not build
 drake

drake_bazel_external_legacy/.github/ci_build_test

@@ -7,7 +7,6 @@ set -euxo pipefail
 # rather than the URL to the latest Drake master branch
 # found in drake_bazel_external_legacy/WORKSPACE.
 export EXAMPLES_LOCAL_DRAKE_PATH=$(realpath drake)
-trap 'unset EXAMPLES_LOCAL_DRAKE_PATH' EXIT
 
 bazel version
 bazel test //...

drake_cmake_external/.github/ci_build_test

@@ -29,21 +29,14 @@ pushd build
 
 export LD_LIBRARY_PATH="${PWD}/install/lib${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}"
 
-cmake_args=()
+cmake_commit_arg=
 if [[ ! -z "${drake_commit_hash}" ]]; then
   # Use a specific commit of Drake source,
   # rather than the latest from master.
-  cmake_args+=(-DDRAKE_COMMIT_HASH=${drake_commit_hash})
-
-  # Find the SHA-256 by downloading and running shasum.
-  wget -O drake.tar.gz \
-    https://github.com/RobotLocomotion/drake/archive/${drake_commit_hash}.tar.gz
-  trap 'rm -f drake.tar.gz' EXIT
-  drake_commit_sha256=$(echo $(shasum -a 256 drake.tar.gz | awk '{print $1}'))
-  cmake_args+=(-DDRAKE_COMMIT_SHA256=${drake_commit_sha256})
+  cmake_commit_arg="-DDRAKE_COMMIT_HASH=${drake_commit_hash}"
 fi
 
-cmake .. "${cmake_args[@]}"
+cmake .. "${cmake_commit_arg}"
 cmake --build .
 
 cd drake_external_examples

drake_cmake_external/CMakeLists.txt

@@ -94,8 +94,7 @@ ExternalProject_Add(spdlog
 set(DRAKE_PREFIX "${PROJECT_BINARY_DIR}/drake-prefix")
 
 # Options to override Drake's latest source on master with a specific commit.
-# Download https://github.com/RobotLocomotion/drake/archive/${DRAKE_COMMIT_HASH}.tar.gz
-# and use "shasum -a 256 'xxx.tar.gz'" on it to get the DRAKE_COMMIT_SHA256.
+# See README.md for details.
 set(DRAKE_COMMIT_HASH "master" CACHE STRING "Commit hash for Drake")
 set(DRAKE_COMMIT_SHA256 CACHE STRING "SHA256 hash value for Drake commit archive")