Skip to content

Commit b1106af

Browse files
authored
Merge pull request #2 from RomanPodymov/master
A small refactoring
2 parents b2d29f6 + 6a078b0 commit b1106af

14 files changed

+446
-352
lines changed

ACSlider/Classes/ACSlider.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ public final class ACSlider: UIControl {
3737
}()
3838

3939

40-
private let minTrackView: UIView = ACSlider.prepareTrackView()
41-
private let maxTrackView: UIView = ACSlider.prepareTrackView()
40+
private let minTrackView = ACSlider.prepareTrackView()
41+
private let maxTrackView = ACSlider.prepareTrackView()
4242

4343
private static func prepareTrackView() -> UIView {
4444
let view = UIView(frame: .zero)

ACSlider/Classes/ThumbView.swift

+19-15
Original file line numberDiff line numberDiff line change
@@ -25,22 +25,22 @@ final class ThumbView: UIView {
2525

2626
// MARK: -
2727

28-
private var valueLabel: UILabel = {
28+
private let valueLabel: UILabel = {
2929
let label = UILabel(frame: .zero)
3030
label.textAlignment = .center
3131
label.text = "00"
3232

3333
return label
3434
}()
3535

36-
private var titleLabel: UILabel = {
36+
private let titleLabel: UILabel = {
3737
let label = UILabel(frame: .zero)
3838
label.textAlignment = .center
3939

4040
return label
4141
}()
4242

43-
private var thumbView: UIView = {
43+
private let thumbView: UIView = {
4444
return CircleView(frame: .zero)
4545
}()
4646

@@ -71,10 +71,7 @@ final class ThumbView: UIView {
7171
addSubview(thumbView)
7272

7373
configureLayout()
74-
75-
valueLabel.textColor = tintColor
76-
titleLabel.textColor = tintColor
77-
thumbView.tintColor = tintColor
74+
configureTintColor()
7875

7976
thumbView.transform = CGAffineTransform(scaleX: 0,
8077
y: 0)
@@ -100,7 +97,10 @@ final class ThumbView: UIView {
10097

10198
override func tintColorDidChange() {
10299
super.tintColorDidChange()
103-
100+
configureTintColor()
101+
}
102+
103+
private func configureTintColor() {
104104
valueLabel.textColor = tintColor
105105
titleLabel.textColor = tintColor
106106
thumbView.tintColor = tintColor
@@ -111,21 +111,25 @@ final class ThumbView: UIView {
111111

112112
func animateTrackingBegin() {
113113
UIView.animateEasy {
114-
self.valueLabel.transform = CGAffineTransform(translationX: 0, y: -50)
115-
self.thumbView.transform = CGAffineTransform.identity
116-
self.thumbView.alpha = 1
114+
self.animateTracking(valueLabelTransform: CGAffineTransform(translationX: 0, y: -50),
115+
thumbViewTransform: .identity,
116+
thumbViewAlpha: 1)
117117
}
118118
}
119119

120120
func animateTrackingEnd() {
121121
UIView.animateEasy {
122-
self.valueLabel.transform = CGAffineTransform.identity
123-
self.thumbView.transform = CGAffineTransform(scaleX: 0,
124-
y: 0)
125-
self.thumbView.alpha = 0
122+
self.animateTracking(valueLabelTransform: .identity,
123+
thumbViewTransform: CGAffineTransform(scaleX: 0, y: 0),
124+
thumbViewAlpha: 0)
126125
}
127126
}
128127

128+
private func animateTracking(valueLabelTransform: CGAffineTransform, thumbViewTransform: CGAffineTransform, thumbViewAlpha: CGFloat) {
129+
self.valueLabel.transform = valueLabelTransform
130+
self.thumbView.transform = thumbViewTransform
131+
self.thumbView.alpha = thumbViewAlpha
132+
}
129133
}
130134

131135

Example/ACSlider.xcodeproj/project.pbxproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@
211211
files = (
212212
);
213213
inputPaths = (
214-
"${SRCROOT}/Pods/Target Support Files/Pods-ACSlider_Example/Pods-ACSlider_Example-frameworks.sh",
214+
"${PODS_ROOT}/Target Support Files/Pods-ACSlider_Example/Pods-ACSlider_Example-frameworks.sh",
215215
"${BUILT_PRODUCTS_DIR}/ACSlider/ACSlider.framework",
216216
);
217217
name = "[CP] Embed Pods Frameworks";
@@ -220,7 +220,7 @@
220220
);
221221
runOnlyForDeploymentPostprocessing = 0;
222222
shellPath = /bin/sh;
223-
shellScript = "\"${SRCROOT}/Pods/Target Support Files/Pods-ACSlider_Example/Pods-ACSlider_Example-frameworks.sh\"\n";
223+
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-ACSlider_Example/Pods-ACSlider_Example-frameworks.sh\"\n";
224224
showEnvVarsInLog = 0;
225225
};
226226
/* End PBXShellScriptBuildPhase section */

Example/Podfile.lock

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
PODS:
2-
- ACSlider (1.0.0)
2+
- ACSlider (1.0.2)
33

44
DEPENDENCIES:
55
- ACSlider (from `../`)
@@ -9,8 +9,8 @@ EXTERNAL SOURCES:
99
:path: "../"
1010

1111
SPEC CHECKSUMS:
12-
ACSlider: bbc8641182c97c7ae40dead275183dec880079f1
12+
ACSlider: dfc421d970c21c2546f1cfb3b2d6fa241bca1c43
1313

1414
PODFILE CHECKSUM: 9369b59a92972a0bcc86321dd5a8a2e36da80f40
1515

16-
COCOAPODS: 1.5.3
16+
COCOAPODS: 1.6.0

Example/Pods/Local Podspecs/ACSlider.podspec.json

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Example/Pods/Manifest.lock

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)