Skip to content

3.x: Add validator to check the existence of throwIfFatal in a catch block #6796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
akarnokd opened this issue Dec 26, 2019 · 0 comments · Fixed by #6801
Closed

3.x: Add validator to check the existence of throwIfFatal in a catch block #6796

akarnokd opened this issue Dec 26, 2019 · 0 comments · Fixed by #6801
Labels
3.x Cleanup
Milestone
3.0

Comments

@akarnokd
Copy link
Member

Scan src/main/java for the following pattern:

} catch (Throwable 
Exceptions.throwIfFatal(

however, allow free pass for

} catch (Throwable 
// Exceptions.throwIfFatal(

As an indicator the fatals are handled in other ways.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.x Cleanup
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

3.x: Add missing throwIfFatal calls akarnokd/RxJava
1 participant
@akarnokd