Skip to content

Tasks view in Eclipse not showing TODOs #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paulvi opened this issue Apr 9, 2014 · 7 comments
Closed

Tasks view in Eclipse not showing TODOs #143

paulvi opened this issue Apr 9, 2014 · 7 comments

Comments

@paulvi
Copy link
Member

paulvi commented Apr 9, 2014

For discussion started at http://stackoverflow.com/questions/22881044/tasks-view-in-eclipse-not-showing-todos

@paulvi
Copy link
Member Author

paulvi commented Apr 9, 2014

Go to Project->Properties->Javascript->Include Path and on tab "Source" add an exclusion pattern for node_modules/*/

that produces file\.settings\.jsdtscope

<?xml version="1.0" encoding="UTF-8"?>
<classpath>
    <classpathentry excluding="node_modules/**/*" kind="src" path=""/>
    <classpathentry kind="con" path="org.eclipse.wst.jsdt.launching.JRE_CONTAINER"/>
    <classpathentry kind="output" path=""/>
</classpath>

also 2 files: org.eclipse.wst.jsdt.ui.superType.container and org.eclipse.wst.jsdt.ui.superType.name

UPDATE:

This approach is likely to be wrong, as it really excluded folder from source, while we need to exclude from validation and TODOs checking.
node_modules should be within source as sometimes JSDT can guess type (e.g. by analysing JSDocs annotations)

UPDATE 2:

OK with first step above, then
go to Project -> Properties -> Javascript -> Include Path, choose the "Libraries" tab, click "Add a library folder..." and set it to the node_modules subfolder.

node_modules-2-as-lib-folder

node_modules-3-project-overview-after-configuration

@paulvi
Copy link
Member Author

paulvi commented Apr 9, 2014

Update I have found click-through on http.createServer(app) to connect library (that is actually wrong, as http in app.js is Node.js base module)

node_modules-4-click-through-create-server

And this work with and without newer template.

So benefit of newer template is questionable (only for TODOs). Now it would only add TODOs list (if jsdt validator buld is enabled)

@BadIdeaException
Copy link

Hi again. :) Sorry, am confused by your last post. What do you mean by having found click-through on http.createServer? And what issue did it produce?

@paulvi
Copy link
Member Author

paulvi commented Apr 9, 2014

Just try click-through (i.e. holding Ctrl clicking on functions)

JSDT can find definitions, even though is not aware of CommonJS modules (aka require)

paulvi added a commit that referenced this issue Apr 9, 2014
@paulvi
Copy link
Member Author

paulvi commented Apr 9, 2014

@chris-33 Look at 4fd3a03 for new project config

That will be released with next 0.15 and should close this issue #143

@paulvi paulvi added this to the 0.15 milestone Apr 9, 2014
paulvi added a commit to Nodeclipse/www.nodeclipse.org that referenced this issue Apr 9, 2014
@paulvi paulvi closed this as completed Apr 30, 2014
@BadIdeaException
Copy link

Hey sorry for the late reply, somehow I didn't see your earlier answer. That was a quick fix! thumbs up

@paulvi
Copy link
Member Author

paulvi commented May 2, 2014

Yes, already released. Configuration is now correct, but builders in .project do not have jsdt builder when creating with Wizard (not with Nodeclipse CLI)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants