Skip to content

Commit 1bd9b1f

Browse files
committed
fix: Remove ember-cli-string-helpers
- This pulls @ember/string 3.1.1 into dependent project and that causes a lot of issues - Since we have `capitalize` in @ember/string, we can just call that in our internal helper - Also bumped internal version of @ember/string to v4.x Fixes ember-learn#1666
1 parent 52d8cbe commit 1bd9b1f

File tree

5 files changed

+104
-194
lines changed

5 files changed

+104
-194
lines changed

addon/helpers/capitalize.js

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import { helper } from '@ember/component/helper';
2+
import { capitalize } from '@ember/string';
3+
4+
export default helper(function capitalizeHelper(positional) {
5+
return capitalize(positional[0]);
6+
});

app/helpers/capitalize.js

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export { default } from 'ember-cli-addon-docs/helpers/capitalize';

package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
"ember-cli-clipboard": "^1.2.1",
5454
"ember-cli-htmlbars": "^6.3.0",
5555
"ember-cli-postcss": "^8.2.0",
56-
"ember-cli-string-helpers": "^6.1.0",
5756
"ember-cli-string-utils": "^1.1.0",
5857
"ember-cli-version-checker": "^5.1.2",
5958
"ember-code-snippet": "^3.0.0",
@@ -111,7 +110,7 @@
111110
"@ember-data/serializer": "^5.3.9",
112111
"@ember-data/store": "^5.3.9",
113112
"@ember/optional-features": "^2.2.0",
114-
"@ember/string": "^3.1.1",
113+
"@ember/string": "^4.0.0",
115114
"@ember/test-helpers": "^3.3.1",
116115
"@embroider/test-setup": "^3.0.3",
117116
"@fullhuman/postcss-purgecss": "^4.1.3",

0 commit comments

Comments
 (0)