Skip to content

Trying to rearrange the welcome tab causes an exception #12921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
Zurtar opened this issue Apr 11, 2025 · 8 comments
Open
2 tasks done

Trying to rearrange the welcome tab causes an exception #12921

Zurtar opened this issue Apr 11, 2025 · 8 comments
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: welcome-tab good first issue An issue intended for project-newcomers. Varies in difficulty. 🔔 reminder-sent

Comments

@Zurtar
Copy link
Contributor

Zurtar commented Apr 11, 2025

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

Build date: 2025-04-11

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Disable the setting to "Hide Tab bar when single library is present"
  2. Create a library (Or create 2 if you skipped step 1)
  3. Click and drag the Welcome tab and move it beside the newly created library
  4. Error occurs

image

Appendix

...

Log File
Paste an excerpt of your log file here
@github-project-automation github-project-automation bot moved this to Normal priority in Prioritization Apr 11, 2025
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Apr 11, 2025
@Siedlerchr Siedlerchr added component: entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. labels Apr 11, 2025
@harshithsaiv
Copy link

Hi @Siedlerchr I'd like to work on this issue.

From the exception, it looks like the WelcomeTab is being incorrectly treated as a LibraryTab, possibly during tab reordering. I believe this is due to type assumptions.

  • I’ll first identify where the Tab list is being accessed and cast to LibraryTab.
  • I’ll add proper instanceof checks to safely handle mixed tab types (WelcomeTab, LibraryTab, etc.).
  • I’ll also include a unit/integration test to reproduce this drag-and-drop scenario and ensure it doesn’t crash.

Please assign this issue to me. I'd be happy to take it forward.

Copy link
Contributor

👋 Hey @harshithsaiv, looks like you’re eager to work on this issue—great! 🎉 It also looks like you skipped reading our CONTRIBUTING.md, which explains exactly how to participate. No worries, it happens to the best of us. Give it a read, and you’ll discover the ancient wisdom of assigning issues to yourself. Trust me, it’s worth it. 🚀

@harshithsaiv
Copy link

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Apr 12, 2025
Copy link
Contributor

👋 Hey @harshithsaiv, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

@koppor koppor moved this from Free to take to Assigned in Good First Issues Apr 12, 2025
@koppor
Copy link
Member

koppor commented Apr 12, 2025

@harshithsaiv

  • I’ll also include a unit/integration test to reproduce this drag-and-drop scenario and ensure it doesn’t crash.

I am very curious how you are going to manage that.

The text seems to be generated by an AI - or do you really know how to run TestFX or other UI testing frameworks?

@harshithsaiv
Copy link

harshithsaiv commented Apr 12, 2025

Hi @koppor , I have knowledge about testing frameworks like Junit , TestNG and I wanted to write test case in TestFx so that we will be able to catch such UI errors

@koppor
Copy link
Member

koppor commented Apr 19, 2025

@harshithsaiv Sounds good. Looking forward!

Copy link
Contributor

github-actions bot commented May 5, 2025

⏰ Assignment Reminder

Hi @harshithsaiv, this is a friendly reminder about your assignment to this issue.

Warning

This issue will be automatically unassigned in 11 days if there's no activity.

How to keep your assignment


If you are working on it, you can prevent automatic unassignment by:

  • Submitting a draft PR with your progress
  • Asking for the 📌 Pinned label if you need more time

We appreciate your contribution and are here to help if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: welcome-tab good first issue An issue intended for project-newcomers. Varies in difficulty. 🔔 reminder-sent
Projects
Status: Assigned
Status: Normal priority
Development

No branches or pull requests

4 participants