Skip to content

fix: remove package-lock.json #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2021
Merged

fix: remove package-lock.json #42

merged 1 commit into from
May 12, 2021

Conversation

christiancompton
Copy link

@christiancompton christiancompton commented May 12, 2021

Due to the package-lock.json file, GitHub is detecting vulnerabilities in our codebase that do not exist. Since the package-lock.json file is only generated when installing the release management dependencies, these changes remove it before packaging it into a release.

@christiancompton christiancompton requested a review from padamstx May 12, 2021 14:26
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christiancompton christiancompton merged commit ea1230f into main May 12, 2021
@christiancompton christiancompton deleted the pkglock branch May 12, 2021 16:55
mediumTaj pushed a commit that referenced this pull request May 12, 2021
## [1.2.3](v1.2.2...v1.2.3) (2021-05-12)

### Bug Fixes

* remove package-lock.json ([#42](#42)) ([ea1230f](ea1230f))
@mediumTaj
Copy link
Member

🎉 This PR is included in version 1.2.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants