Skip to content

Commit c3d4cff

Browse files
committed
Remove the test-32bit-cross job
It was not able to test as much as was desired, and there is now a job-level container based way that does a full 32-but ARMv7 test (facilitated by the new ARM64 runners, which are also able to execute ARMv7 binaries without emulation). The new ARM jobs added in the last couple of commits, consisting of a 64-bit job in `test-fast` and a 32-bit job in `test-32bit`, increase the total time and resources required to run CI checks. Removing `test-32bit-cross` only slightly counteracts that. But it is also less needed now.
1 parent fbc27b5 commit c3d4cff

File tree

1 file changed

+0
-30
lines changed

1 file changed

+0
-30
lines changed

.github/workflows/ci.yml

-30
Original file line numberDiff line numberDiff line change
@@ -251,35 +251,6 @@ jobs:
251251
GIX_TEST_IGNORE_ARCHIVES: '1'
252252
run: cargo nextest run --workspace --no-fail-fast
253253

254-
test-32bit-cross:
255-
runs-on: ubuntu-latest
256-
257-
strategy:
258-
matrix:
259-
target: [ armv7-linux-androideabi ]
260-
261-
steps:
262-
- uses: actions/checkout@v4
263-
- uses: dtolnay/rust-toolchain@stable
264-
- uses: Swatinem/rust-cache@v2
265-
- name: Install Rust
266-
uses: dtolnay/rust-toolchain@master
267-
with:
268-
toolchain: stable
269-
targets: ${{ matrix.target }}
270-
- name: Install cross
271-
uses: taiki-e/install-action@v2
272-
with:
273-
tool: cross
274-
- name: check
275-
run: cross check -p gix --target ${{ matrix.target }}
276-
- name: Test (unit)
277-
run: |
278-
# Run some high-level unit tests that exercise various pure Rust code to ease building
279-
# test binaries. We would prefer `-p gix`. But with `cross`, fixture scripts try to run
280-
# the host `git` as an armv7 binary.
281-
cross test -p gix-hashtable --target ${{ matrix.target }}
282-
283254
lint:
284255
runs-on: ubuntu-latest
285256

@@ -455,7 +426,6 @@ jobs:
455426
- test-journey
456427
- test-fast
457428
- test-32bit
458-
- test-32bit-cross
459429
- lint
460430
- cargo-deny
461431
- check-packetline

0 commit comments

Comments
 (0)