Skip to content

Commit 7838f69

Browse files
silverwindwxiaoguang
authored andcommitted
Fix JS error when opening to expanded code comment (go-gitea#30463)
Fix regression from go-gitea@e0b0187 where opening to a code comment via hash link would give this error: <img width="1247" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/f9aaeded-8492-4416-9a73-afa0c56220a7"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
1 parent 3735797 commit 7838f69

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

web_src/js/features/repo-issue.js

+3-5
Original file line numberDiff line numberDiff line change
@@ -435,12 +435,10 @@ export function initRepoPullRequestReview() {
435435
offset += $('.diff-detail-box').outerHeight() + $(diffHeader).outerHeight();
436436
}
437437

438-
document.getElementById(`show-outdated-${id}`).classList.add('tw-hidden');
439-
document.getElementById(`code-comments-${id}`).classList.remove('tw-hidden');
440-
document.getElementById(`code-preview-${id}`).classList.remove('tw-hidden');
441-
document.getElementById(`hide-outdated-${id}`).classList.remove('tw-hidden');
438+
hideElem(`#show-outdated-${id}`);
439+
showElem(`#code-comments-${id}, #code-preview-${id}, #hide-outdated-${id}`);
442440
// if the comment box is folded, expand it
443-
if (ancestorDiffBox.getAttribute('data-folded') === 'true') {
441+
if (ancestorDiffBox?.getAttribute('data-folded') === 'true') {
444442
setFileFolding(ancestorDiffBox, ancestorDiffBox.querySelector('.fold-file'), false);
445443
}
446444

0 commit comments

Comments
 (0)