Skip to content

Commit 4062b56

Browse files
committed
Use ubuntu-22.04-arm; clean up temporary changes
In the AArch64/ARM64 (64-bit, non-containerized) test-fast job, this uses the `ubuntu-22.04-arm` runner instead of the `ubuntu-24.04-arm` runner. This is to avoid the errors described in GitoxideLabs#1790, i.e., to work around rust-lang/rust#135867. Such problems have not been observed on the 22.04 runner, including in tests intended to find them, and switching to it seems to be a complete workaround for the problem. In contrast, continuing to use the 24.04 runner, but attempting to work around the problem by switching from the stable to the beta channel, looks like it would greatly decrease the frequency of the errors but not eliminate them. A problem with `actions/checkout` failing is likewise observed on the 24.04 runner only, so using 22.04 avoids that too. Because that seems like a complete workaround, this also reverts 50da7cb (GitoxideLabs#1792). That is to say that the ARM64 test-fast job is again in the `test-fast` matrix. It is capable of cancelling or being cancelled by the other `test-fast` checks. Code duplication in the workflow is somewhat decreased. The job will again block PR auto-merge. Similar errors do not seem to have occurred in the `test-32bit` job that runs an arm32v7 Docker image in `ubuntu-24.04-arm`, and it is not clear that changing the runner image would help with GitoxideLabs#1780, nor even if that issue is still happening. Therefore, it is not changed there at this time. This affects only ARM Linux runners. The x86-64 runners continue to use `ubuntu-latest`, which is currently resolved to `ubuntu-24.04`, and that does not need to be changed. Likewise, the `macos-latest` runners use ARM processors (Apple Silicon) and they are fine. Various experiments were done in a separate workflow. This commit also removes that workflow, because it is not actively needed anymore, and because, if kept, it would have to be modified to avoid running hundreds of extra checks on each and every push.
1 parent a0e923b commit 4062b56

File tree

2 files changed

+1
-70
lines changed

2 files changed

+1
-70
lines changed

.github/workflows/arm-segv-experiment.yml

-50
This file was deleted.

.github/workflows/ci.yml

+1-20
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ jobs:
135135
- windows-latest
136136
- macos-latest
137137
- ubuntu-latest
138+
- ubuntu-22.04-arm
138139

139140
runs-on: ${{ matrix.os }}
140141

@@ -160,25 +161,6 @@ jobs:
160161
- name: Check that tracked archives are up to date
161162
run: git diff --exit-code # If this fails, the fix is usually to commit a regenerated archive.
162163

163-
test-fast-arm:
164-
runs-on: ubuntu-24.04-arm
165-
166-
steps:
167-
- uses: actions/checkout@v4
168-
- uses: dtolnay/rust-toolchain@stable
169-
- uses: Swatinem/rust-cache@v2
170-
- uses: taiki-e/install-action@v2
171-
with:
172-
tool: nextest
173-
- name: Test (nextest)
174-
env:
175-
GIX_TEST_CREATE_ARCHIVES_EVEN_ON_CI: '1'
176-
run: cargo nextest run --workspace --no-fail-fast
177-
- name: Doctest
178-
run: cargo test --workspace --doc --no-fail-fast
179-
- name: Check that tracked archives are up to date
180-
run: git diff --exit-code # If this fails, the fix is usually to commit a regenerated archive.
181-
182164
test-fixtures-windows:
183165
runs-on: windows-latest
184166

@@ -405,7 +387,6 @@ jobs:
405387
env:
406388
# List all jobs that are intended NOT to block PR auto-merge here.
407389
EXPECTED_NONBLOCKING_JOBS: |-
408-
test-fast-arm
409390
cargo-deny-advisories
410391
wasm
411392
tests-pass

0 commit comments

Comments
 (0)