Address PR feedback to pull a builder helper out to reduce duplication

Author: Brian Morton

lib/graphql/persisted_queries.rb

@@ -4,6 +4,7 @@
 require "graphql/persisted_queries/schema_patch"
 require "graphql/persisted_queries/store_adapters"
 require "graphql/persisted_queries/version"
+require "graphql/persisted_queries/builder_helpers"
 
 module GraphQL
   # Plugin definition

lib/graphql/persisted_queries/builder_helpers.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module GraphQL
+  module PersistedQueries
+    # Contains factory methods for error handlers
+    module BuilderHelpers
+      def self.camelize(name)
+        name.to_s.split("_").map(&:capitalize).join
+      end
+    end
+  end
+end

lib/graphql/persisted_queries/error_handlers.rb

@@ -26,9 +26,7 @@ def self.build_from_proc(proc)
       end
 
       def self.build_by_name(name, options)
-        camelized_handler = name.to_s.split("_").map(&:capitalize).join
-        handler_class_name = "#{camelized_handler}ErrorHandler"
-        ErrorHandlers.const_get(handler_class_name).new(options || {})
+        const_get("#{BuilderHelpers.camelize(name)}ErrorHandler").new(options || {})
       rescue NameError => e
         raise e.class, "Persisted query error handler for :#{name} haven't been found", e.backtrace
       end

lib/graphql/persisted_queries/store_adapters.rb

@@ -17,9 +17,7 @@ def self.build(adapter, options = nil)
       end
 
       def self.build_by_name(name, options)
-        camelized_adapter = name.to_s.split("_").map(&:capitalize).join
-        adapter_class_name = "#{camelized_adapter}StoreAdapter"
-        StoreAdapters.const_get(adapter_class_name).new(options || {})
+        const_get("#{BuilderHelpers.camelize(name)}StoreAdapter").new(options || {})
       rescue NameError => e
         raise e.class, "Persisted query store adapter for :#{name} haven't been found", e.backtrace
       end

spec/graphql/persisted_queries/builder_helpers_spec.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+RSpec.describe GraphQL::PersistedQueries::BuilderHelpers do
+  describe ".camelize" do
+    let(:name) { nil }
+    subject { described_class.camelize(name) }
+
+    context "when a symbol is passed" do
+      let(:name) { :this_is_a_test }
+
+      it { is_expected.to eq("ThisIsATest") }
+    end
+  end
+end