Skip to content

Vulnerabilities due to yarn.lock file #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ArtemisMucaj opened this issue Oct 23, 2023 · 5 comments
Closed

Vulnerabilities due to yarn.lock file #13

ArtemisMucaj opened this issue Oct 23, 2023 · 5 comments

Comments

@ArtemisMucaj
Copy link

ArtemisMucaj commented Oct 23, 2023

Hi,

We've started using https://github.com/thephpleague/openapi-psr7-validator in a few services and it's been great so far. Thank you for your support in maintaining this fork.

I've come to you because we've had reports of vulnerabilities in our CD/CI jobs.

Screenshot from 2023-10-23 14-28-06

These seem to be related to the yarn.lock file which is present in the package artifacts and has a few critical vulnerabilities. Is this wanted behavior ? If so would you consider upgrading them to fix the vulnerabilities?

Thanks in advance,

Artemis

@WyriHaximus
Copy link
Collaborator

@DEVizzent Honestly I don't think it should be included in the tarball. But we also would want to update the dependencies in there. You prefer automation like Renovate or Dependebot for that?

@ArtemisMucaj
Copy link
Author

I wouldn't include them in the tarball neither. Which seems to be possible by specifying an exclude list in the composer.json file

https://getcomposer.org/doc/04-schema.md#archive

@DEVizzent
Copy link
Owner

@ArtemisMucaj It makes sense. I will do it Thusday afternoon.
@WyriHaximus I usually worked previously with Dependabot, but if you like more Renovate we can try it 👍

@DEVizzent
Copy link
Owner

Please @ArtemisMucaj . Confirm it is fixed

@ArtemisMucaj
Copy link
Author

Your PR fixed our issue! Thank you so much for your reactivity! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants