fix other errors and clean some code

Author: BenjaminCanape

lib/presentation/community/screens/pending_requests_screen.dart

@@ -34,8 +34,7 @@ class PendingRequestsScreen extends HookConsumerWidget {
               UIUtils.createHeader(
                   AppLocalizations.of(context)!.pending_requests_title),
               const SizedBox(height: 40),
-              Expanded(
-                  child: pendingRequestsStateProvider.when(
+              pendingRequestsStateProvider.when(
                 data: (initialData) {
                   return PendingRequestsListWidget(
                     users: initialData.list,
@@ -51,7 +50,7 @@ class PendingRequestsScreen extends HookConsumerWidget {
                 error: (error, stackTrace) {
                   return Text('$error');
                 },
-              ))
+              )
             ])),
             floatingActionButtonLocation:
                 FloatingActionButtonLocation.centerFloat,

lib/presentation/community/widgets/pending_request_list.dart

@@ -14,43 +14,17 @@ class PendingRequestsListWidget extends HookConsumerWidget {
   final Function(String) onReject;
   final Future<EntityPage<User>> Function({int pageNumber}) bottomListScrollFct;
 
-  final ScrollController _scrollController = ScrollController();
-
-  PendingRequestsListWidget(
+  const PendingRequestsListWidget(
       {super.key,
       required this.users,
       required this.total,
       required this.onAccept,
       required this.onReject,
       required this.bottomListScrollFct});
 
-  void onScroll() {
-    if (_scrollController.position.pixels ==
-        _scrollController.position.maxScrollExtent) {}
-  }
-
   @override
   Widget build(BuildContext context, WidgetRef ref) {
-    _scrollController.addListener(onScroll);
-    /*return ListView.builder(
-      controller: _scrollController,
-      itemCount: users.length,
-      itemBuilder: (context, index) {
-        final user = users[index];
-        return ListTile(
-          title: Text(
-            UserUtils.getNameOrUsername(user),
-          ),
-          trailing: AcceptRefuseWidget(
-            userId: user.id,
-            onAccept: onAccept,
-            onReject: onReject,
-          ),
-        );
-      },
-    );*/
-    return Expanded(
-        child: InfiniteScrollList(
+    return InfiniteScrollList(
       listId: 'PENDING_REQUESTS',
       initialData: users,
       total: total,
@@ -72,6 +46,6 @@ class PendingRequestsListWidget extends HookConsumerWidget {
           ),
         );
       },
-    ));
+    );
   }
 }

lib/presentation/my_activities/screens/activity_details_screen.dart

@@ -107,10 +107,8 @@ class ActivityDetailsScreen extends HookConsumerWidget {
                               body: TabBarView(
                                   controller: tabController,
                                   children: [
-                                    Expanded(
-                                        child: DetailsTab(activity: activity)),
-                                    Expanded(
-                                        child: GraphTab(activity: activity))
+                                    DetailsTab(activity: activity),
+                                    GraphTab(activity: activity)
                                   ]))))
                 ],
               ),