Skip to content

Commit b20c41c

Browse files
committed
feat(Selection): Updates
* Make CSS classes snake-case to stay consistent with established standards * Add OK icon from fontello to ui-grid icon set config * Make unselected row header have a low-opacity check mark to hint user what the available action is.
1 parent cf14396 commit b20c41c

File tree

3 files changed

+32
-20
lines changed

3 files changed

+32
-20
lines changed

src/features/selection/less/selection.less

+8-2
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,16 @@
1616
cursor: default;
1717
}
1818

19-
.uiGridSelectionRowHeaderButtons {
19+
.ui-grid-selection-row-header-buttons {
2020
cursor: pointer;
21+
opacity: 0.1;
22+
23+
&.ui-grid-row-selected {
24+
opacity: 1;
25+
}
2126
}
2227

23-
.uiGridSelectionRowHeaderCell {
28+
// TODO: remove? I can't find this class used anywhere, even with the camelCase name
29+
.ui-grid-selection-row-header-cell {
2430
border-bottom: solid @gridBorderWidth @borderColor;
2531
}
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
<div class="uiGridSelectionRowHeaderButtons" ng-class="{'icon-ok': row.isSelected}" ng-click="selectButtonClick(row, $event)">
2-
&nbsp
1+
<div class="ui-grid-selection-row-header-buttons ui-grid-icon-ok" ng-class="{'ui-grid-row-selected': row.isSelected}" ng-click="selectButtonClick(row, $event)">
2+
&nbsp;
33
</div>

src/font/config.json

+22-16
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,41 @@
77
"ascent": 850,
88
"glyphs": [
99
{
10-
"uid": "1a5cfa186647e8c929c2b17b9fc4dac1",
11-
"css": "plus-squared",
12-
"code": 50000,
13-
"src": "fontawesome"
14-
},
15-
{
16-
"uid": "f755a58fb985eeb70bd47d9b31892a34",
17-
"css": "minus-squared",
18-
"code": 50001,
19-
"src": "fontawesome"
10+
"uid": "5d2d07f112b8de19f2c0dbfec3e42c05",
11+
"css": "spin5",
12+
"code": 60001,
13+
"src": "fontelico"
2014
},
2115
{
2216
"uid": "9dd9e835aebe1060ba7190ad2b2ed951",
2317
"css": "search",
2418
"code": 50002,
2519
"src": "fontawesome"
2620
},
21+
{
22+
"uid": "12f4ece88e46abd864e40b35e05b11cd",
23+
"css": "ok",
24+
"code": 59392,
25+
"src": "fontawesome"
26+
},
2727
{
2828
"uid": "5211af474d3a9848f67f945e2ccaf143",
2929
"css": "cancel",
3030
"code": 50003,
3131
"src": "fontawesome"
3232
},
33+
{
34+
"uid": "1a5cfa186647e8c929c2b17b9fc4dac1",
35+
"css": "plus-squared",
36+
"code": 50000,
37+
"src": "fontawesome"
38+
},
39+
{
40+
"uid": "f755a58fb985eeb70bd47d9b31892a34",
41+
"css": "minus-squared",
42+
"code": 50001,
43+
"src": "fontawesome"
44+
},
3345
{
3446
"uid": "e82cedfa1d5f15b00c5a81c9bd731ea2",
3547
"css": "info-circled",
@@ -113,12 +125,6 @@
113125
"css": "sort-alt-down",
114126
"code": 50017,
115127
"src": "fontawesome"
116-
},
117-
{
118-
"uid": "5d2d07f112b8de19f2c0dbfec3e42c05",
119-
"css": "spin5",
120-
"code": 60001,
121-
"src": "fontelico"
122128
}
123129
]
124130
}

0 commit comments

Comments
 (0)