Skip to content

Commit 9927b71

Browse files
cybermerlinmportuga
authored andcommitted
fix(ui-grid-render-container): Use offsetHeight to avoid sizing issues.
Also, revert 76e18d6. fix #6480
1 parent fe09141 commit 9927b71

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

src/js/core/directives/ui-grid-render-container.js

+9-1
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,15 @@
157157
ret += '\n .grid' + uiGridCtrl.grid.id + ' .ui-grid-render-container-' + $scope.containerId + ' .ui-grid-header-canvas { width: ' + (canvasWidth + grid.scrollbarWidth) + 'px; }';
158158

159159
if (renderContainer.explicitHeaderCanvasHeight) {
160-
ret += '\n .grid' + uiGridCtrl.grid.id + ' .ui-grid-render-container-' + $scope.containerId + ' .ui-grid-header-canvas { height: ' + renderContainer.explicitHeaderCanvasHeight + 'px; }';
160+
// get height from body container
161+
var reHCHeight = document.querySelector('.grid'+uiGridCtrl.grid.id+' .ui-grid-render-container-body .ui-grid-header-canvas');
162+
163+
if (reHCHeight) {
164+
renderContainer.explicitHeaderCanvasHeight = reHCHeight.offsetHeight;
165+
}
166+
167+
ret += '\n .grid' + uiGridCtrl.grid.id + ' .ui-grid-render-container-' + $scope.containerId +
168+
' .ui-grid-header-canvas { height: ' + renderContainer.explicitHeaderCanvasHeight + 'px; }';
161169
}
162170
else {
163171
ret += '\n .grid' + uiGridCtrl.grid.id + ' .ui-grid-render-container-' + $scope.containerId + ' .ui-grid-header-canvas { height: inherit; }';

src/js/core/factories/Grid.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -2159,8 +2159,8 @@ angular.module('ui.grid')
21592159
}
21602160

21612161
if (container.header || container.headerCanvas) {
2162-
container.explicitHeaderHeight = null;
2163-
container.explicitHeaderCanvasHeight = null;
2162+
container.explicitHeaderHeight = container.explicitHeaderHeight || null;
2163+
container.explicitHeaderCanvasHeight = container.explicitHeaderCanvasHeight || null;
21642164

21652165
containerHeadersToRecalc.push(container);
21662166
}

0 commit comments

Comments
 (0)