Skip to content

Commit 4892fbc

Browse files
committed
fix(customizer): point to ui-grid-unstable.css at top of page
1 parent bd5f6ec commit 4892fbc

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

TODO.md

+15-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,21 @@
1616
1. Maybe we can just do another conditional on process.env.TRAVIS and add the <%= site %> on as a prefix.
1717
1. [IDEA] add a test that, during a scroll event, spies on number of reads/writes to DOM properties that cause reflow
1818
1. [IDEA] - For grid search, if the grid has focus and the user presses ctrl/cmd+F we can pop up the search box.
19-
1. [BUG] - Viewport is intermittently calcuating too small on customizer page
20-
1. [BUG] - On uiGrid directive example, the scrollbar is showing up when there's nothing to scroll... then it disappears on scroll
19+
1. [BUG] - Viewport is calcuating too small on customizer page on ui-grid.info ONLY.
20+
1. [BUG] - On uiGrid directive example in API docs, the scrollbar is showing up when there's nothing to scroll... then it disappears on scroll
21+
1. [IDEA] - Handle dynamic row sizes
22+
- Once a row is rendered outside the viewport for the first time, calculate its height and store it
23+
- For each stored height, remove one default height (30px now) from the calculation and replace it with this dynamic value.
24+
- i.e. if there are 10 rows at 30px default a piece, that's 300px canvas height. Newly-rendered row is 50px, so subtract 30px from 300px (270px) and add 50px (320px)
25+
- This would need to prevent the scrollTop on the viewport and scrollbar from changing. The percentages would probably change as the canvas height changes, and we'd need them to not jerky back or forward.
26+
- So in the uiGridBody it knows the indexes of the rows being rendered. It can just tell each row to calculate its own height in an $evalAsync.
27+
- Or perhaps the row heights can be calculated all at once in the body so we are not running N number of $evalAsync functions.
28+
- Invalidate row heights on data changes
29+
1. Add scrollbar border variable
30+
1. Add theming to customizer
31+
1. Add jade processing for misc/site directory
32+
- Don't `copy` .jade files with the copy task.
33+
1. Make scrollbar look like chrome's?
2134

2235
# Done!
2336

misc/site/customizer/index.html

+3-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<link rel="stylesheet" href="/docs/css/bootstrap-flatly.css" />
1111
<link rel="stylesheet" href="//netdna.bootstrapcdn.com/font-awesome/4.0.3/css/font-awesome.min.css" />
1212
<link rel="stylesheet" href="/css/site.css" />
13-
<link rel="stylesheet" href="/release/ui-grid.css" />
13+
<link rel="stylesheet" href="/release/ui-grid-unstable.css" />
1414
<style>
1515
.compiled-css {
1616
height: 280px;
@@ -139,7 +139,7 @@ <h3>Download</h3>
139139
</div>
140140

141141
<script src="//cdnjs.cloudflare.com/ajax/libs/less.js/1.6.0/less.min.js"></script>
142-
<script src="//ajax.googleapis.com/ajax/libs/jquery/2.0.3/jquery.min.js"></script>
142+
<script src="//ajax.googleapis.com/ajax/libs/jquery/2.0.3/jquery.js"></script>
143143

144144
<!--
145145
<script src="//cdnjs.cloudflare.com/ajax/libs/zeroclipboard/1.2.3/ZeroClipboard.js"></script>
@@ -170,6 +170,7 @@ <h3>Download</h3>
170170
s.src = '/release/ui-grid-unstable.js';
171171
}
172172
else {
173+
// s.src = 'http://ui-grid.info/release/ui-grid-unstable.js';// '/release/ui-grid.js';
173174
s.src = '/release/ui-grid.js';
174175
}
175176
document.write(outerHTML(s));

0 commit comments

Comments
 (0)