Skip to content

Commit 025c61b

Browse files
committed
fix(grunt): cut-release wasn't running done()
1 parent 129f28b commit 025c61b

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

.travis.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ script:
3838
- grunt
3939
# - git config credential.helper "store --file=.git/credentials"
4040
# - echo "https://${GITHUB_NAME}:${GITHUB_PASS}@github.com" > .git/credentials
41+
- grunt test:ci
4142
- grunt release
4243

43-
after_success:
44-
- grunt test:ci
44+
# after_success:
4545

4646
after_script:
4747
- ./travis_print_logs.sh

Gruntfile.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ module.exports = function(grunt) {
288288
}
289289
},
290290

291-
cutrelease: {
291+
'cut-release': {
292292
options: {
293293
cleanup: true,
294294
keepUnstable: false
@@ -348,5 +348,5 @@ module.exports = function(grunt) {
348348
}
349349
});
350350

351-
grunt.registerTask('release', ['clean', 'build', 'cutrelease', 'gh-pages']);
351+
grunt.registerTask('release', ['clean', 'build', 'cut-release', 'gh-pages']);
352352
};

TODO.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
1. `readableColumnNames` need to be overrideable by i18n.
44
1. Add banners to compiled .css files (grunt-banner?)
55
1. Add grunt-nuget task to autodeploy builds to nuget
6-
1. Use: git describe --tags `git rev-list --tags --max-count=1`
7-
to replace the code in utils.getVersion();
6+
1. Try to reomve `npm install` commands from travis before-script
87

98
1. [DONE] Add --browsers option for testing on saucelabs with specific browser(s)
109
1. [DONE] Make karmangular run in `watch` mode and in singlerun too.

lib/grunt/plugins.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ module.exports = function(grunt) {
143143
grunt.log.writeln(util.getStableVersion());
144144
});
145145

146-
grunt.registerMultiTask('cutrelease', 'Release the built code', function() {
146+
grunt.registerMultiTask('cut-release', 'Release the built code', function() {
147147
// Require the build and ngdocs tassk to be run first
148148
grunt.task.requires(['build']);
149149

@@ -232,5 +232,7 @@ module.exports = function(grunt) {
232232
}
233233
});
234234
});
235+
236+
done();
235237
});
236238
};

0 commit comments

Comments
 (0)